Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to PostCSS 8 #308

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Update to PostCSS 8 #308

merged 1 commit into from
Feb 4, 2022

Conversation

ibacher
Copy link
Member

@ibacher ibacher commented Feb 4, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

Summary

This is a simple make-work PR to update to PostCSS 8. There is no real reason this needs to happen, but it's also pretty harmless.

Screenshots

Related Issue

Other

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

File size impact

Merging update_postcss into master impact files as follow:

@openmrs/esm-devtools-app (no impact)
Files new size
Unmodified (5) 341 kB (0 B / +0%) 👻
Total (5) 341 kB (0 B / +0%) 👻
@openmrs/esm-implementer-tools-app (no impact)
Files new size
Unmodified (17) 1.6 MB (0 B / +0%) 👻
Total (17) 1.6 MB (0 B / +0%) 👻
@openmrs/esm-login-app (no impact)
Files new size
Unmodified (28) 1.92 MB (0 B / +0%) 👻
Total (28) 1.92 MB (0 B / +0%) 👻
@openmrs/esm-offline-tools-app (no impact)
Files new size
Unmodified (23) 2.39 MB (0 B / +0%) 👻
Total (23) 2.39 MB (0 B / +0%) 👻
@openmrs/esm-primary-navigation-app (no impact)
Files new size
Unmodified (18) 2.05 MB (0 B / +0%) 👻
Total (18) 2.05 MB (0 B / +0%) 👻
@openmrs/esm-app-shell (-0.81%)
Files new size
packages/shell/esm-app-shell/dist/openmrs.css 528 kB (-14.1 kB / -2.6%) ↘️
packages/shell/esm-app-shell/dist/service-worker.js 160 kB (0 B / +0%) 👻
Unmodified (2) 1.04 MB (0 B / +0%) 👻
Total (4) 1.73 MB (-14.1 kB / -0.81%) ↘️
Generated by @jsenv/file-size-impact during Report bundle size#1797038106 on 689e6bb

@brandones brandones merged commit a1bd525 into master Feb 4, 2022
@brandones brandones deleted the update_postcss branch February 4, 2022 23:55
@brandones
Copy link
Collaborator

Thanks Ian! Great to keep up with stuff like this.

@brandones brandones mentioned this pull request Feb 11, 2022
Closed
@brandones
Copy link
Collaborator

This has broken the build; esm-styleguide is not building. Reverting.

brandones added a commit that referenced this pull request Feb 11, 2022
@brandones
Revert "Update to PostCSS 8 (#308)"
48a761d 
This reverts commit a1bd525.
@brandones brandones mentioned this pull request Feb 11, 2022
Closed
@ZacButko ZacButko mentioned this pull request May 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandones brandones brandones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibacher @brandones